[FIX] Handle checking 'installed_games' file for Crossover #4381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
Etaash-mathamsetty,
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
flavioislima
approved these changes
Mar 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in November, an
installed_gamesmetadata file was introduced to detect when a new game is installed in an already created prefix. This was not handling Crossover bottles properly, since it was always using the configured winePrefix of the settings that is not used for Crossover.This PR adds the handling of that, creating the
installed_gamesfile inside the bottle's folder (essentially a wine prefix) by using some verbose crossover output.One thing to note is that this will trigger the installation of redistributables once for each game that's already installed since the
installed_gamesfile is not there yet, but the same is happening now in linux.This fixes #4369
Use the following Checklist if you have changed something on the Backend or Frontend: